yousoph opened a new pull request, #38479: URL: https://github.com/apache/superset/pull/38479
When a filter has both "Filter value is required" (enableEmptyFilter) and "Select first filter value by default" (defaultToFirstItem) enabled, changing other filters would incorrectly disable the Apply button. Root cause: The Apply button validation logic only checked dataMaskSelected for required filter values. When filters auto-apply (e.g., requiredFirst or needsAutoApply scenarios), they update dataMaskApplied immediately but may not have synced to dataMaskSelected yet, causing checkIsMissingRequiredValue to incorrectly return true. Fix: Modified checkIsApplyDisabled to check BOTH dataMaskSelected AND dataMaskApplied when validating required filters. This handles the state synchronization gap during filter initialization and auto-apply scenarios. The fix preserves the original PR #36927 behavior (auto-applying filters with incomplete extraFormData) while addressing the new bug. Tested scenarios: - Required filter with default value + changing other filters - Auto-applied filters during React state sync gap - Original PR #36927 scenario (value with empty extraFormData) - Embedded dashboards (no special handling needed) - Jinja macro prepopulated filters (same fix applies) <!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
