bito-code-review[bot] commented on PR #38479: URL: https://github.com/apache/superset/pull/38479#issuecomment-4023315898
<!-- Bito Reply --> Yes, the suggestion to remove this useEffect is valid — it cleans up validation errors on mount, but gets overwritten by a later useEffect that resets dataMaskSelected to dataMaskApplied, making it dead code. Your testing confirms it works without it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
