bito-code-review[bot] commented on code in PR #38486: URL: https://github.com/apache/superset/pull/38486#discussion_r2899367433
########## docs/scripts/docusaurus.mjs: ########## @@ -0,0 +1,46 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import {spawnSync} from 'child_process'; + +// When launching the docusaurus CLI we want to ensure Node has sufficient +// heap space. In CI we cap at 4GB (4096) to avoid hitting runner limits, +// whereas local development gets 8GB by default. This logic mirrors the +// hardcoded values previously used in package.json scripts. +// +// Usage: `node scripts/docusaurus.mjs <command> [args...]` which is +// equivalent to running `docusaurus <command> [args...]` with the proper +// NODE_OPTIONS value injected. + +// Docusaurus Faster: Rspack bundler, SWC transpilation, and other build +// optimizations. Only enabled for local development — CI runners (GitHub +// Actions, Netlify) have ~8GB RAM and these features push memory usage over +// the limit. See https://docusaurus.io/blog/releases/3.6#docusaurus-faster +const isCI = process.env.CI === 'true'; + +const defaultHeap = isCI ? 4096 : 8192; +if (!process.env.NODE_OPTIONS?.includes('--max-old-space-size')) { + process.env.NODE_OPTIONS = `--max-old-space-size=${defaultHeap}`; +} Review Comment: <div> <div id="suggestion"> <div id="issue"><b>NODE_OPTIONS overwrite bug</b></div> <div id="fix"> The NODE_OPTIONS assignment overwrites the entire variable, potentially losing existing Node.js options. It should append the heap flag to preserve any pre-existing options. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ````suggestion if (!process.env.NODE_OPTIONS?.includes('--max-old-space-size')) { process.env.NODE_OPTIONS = `${process.env.NODE_OPTIONS || ''} --max-old-space-size=${defaultHeap}`; } ```` </div> </details> </div> <small><i>Code Review Run #7d0e49</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
