bito-code-review[bot] commented on code in PR #38486:
URL: https://github.com/apache/superset/pull/38486#discussion_r2899921571
##########
docs/developer_docs/api.mdx:
##########
@@ -68,14 +68,14 @@ curl -H "Authorization: Bearer YOUR_ACCESS_TOKEN" \
| `POST` | [Create a new dashboard](./api/create-a-new-dashboard) |
`/api/v1/dashboard/` |
| `GET` | [Get metadata information about this API resource
(dashboard--info)](./api/get-metadata-information-about-this-api-resource-dashboard-info)
| `/api/v1/dashboard/_info` |
| `GET` | [Get a dashboard detail
information](./api/get-a-dashboard-detail-information) |
`/api/v1/dashboard/{id_or_slug}` |
-| `GET` | [Get a dashboard's chart
definitions.](./api/get-a-dashboard-s-chart-definitions) |
`/api/v1/dashboard/{id_or_slug}/charts` |
+| `GET` | [Get a dashboard's chart
definitions.](./api/get-a-dashboards-chart-definitions) |
`/api/v1/dashboard/{id_or_slug}/charts` |
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Broken documentation link</b></div>
<div id="fix">
The link points to a non-existent file, which will result in broken
documentation navigation.
</div>
</div>
<small><i>Code Review Run #b9726a</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
docs/developer_docs/api.mdx:
##########
@@ -68,14 +68,14 @@ curl -H "Authorization: Bearer YOUR_ACCESS_TOKEN" \
| `POST` | [Create a new dashboard](./api/create-a-new-dashboard) |
`/api/v1/dashboard/` |
| `GET` | [Get metadata information about this API resource
(dashboard--info)](./api/get-metadata-information-about-this-api-resource-dashboard-info)
| `/api/v1/dashboard/_info` |
| `GET` | [Get a dashboard detail
information](./api/get-a-dashboard-detail-information) |
`/api/v1/dashboard/{id_or_slug}` |
-| `GET` | [Get a dashboard's chart
definitions.](./api/get-a-dashboard-s-chart-definitions) |
`/api/v1/dashboard/{id_or_slug}/charts` |
+| `GET` | [Get a dashboard's chart
definitions.](./api/get-a-dashboards-chart-definitions) |
`/api/v1/dashboard/{id_or_slug}/charts` |
| `POST` | [Create a copy of an existing
dashboard](./api/create-a-copy-of-an-existing-dashboard) |
`/api/v1/dashboard/{id_or_slug}/copy/` |
-| `GET` | [Get dashboard's datasets](./api/get-dashboard-s-datasets) |
`/api/v1/dashboard/{id_or_slug}/datasets` |
-| `DELETE` | [Delete a dashboard's embedded
configuration](./api/delete-a-dashboard-s-embedded-configuration) |
`/api/v1/dashboard/{id_or_slug}/embedded` |
-| `GET` | [Get the dashboard's embedded
configuration](./api/get-the-dashboard-s-embedded-configuration) |
`/api/v1/dashboard/{id_or_slug}/embedded` |
-| `POST` | [Set a dashboard's embedded
configuration](./api/set-a-dashboard-s-embedded-configuration) |
`/api/v1/dashboard/{id_or_slug}/embedded` |
+| `GET` | [Get dashboard's datasets](./api/get-dashboards-datasets) |
`/api/v1/dashboard/{id_or_slug}/datasets` |
+| `DELETE` | [Delete a dashboard's embedded
configuration](./api/delete-a-dashboards-embedded-configuration) |
`/api/v1/dashboard/{id_or_slug}/embedded` |
+| `GET` | [Get the dashboard's embedded
configuration](./api/get-the-dashboards-embedded-configuration) |
`/api/v1/dashboard/{id_or_slug}/embedded` |
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Broken documentation link</b></div>
<div id="fix">
The link points to a non-existent file, which will result in broken
documentation navigation.
</div>
</div>
<small><i>Code Review Run #b9726a</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
docs/developer_docs/api.mdx:
##########
@@ -249,7 +249,7 @@ curl -H "Authorization: Bearer YOUR_ACCESS_TOKEN" \
| Method | Endpoint | Description |
|--------|----------|-------------|
-| `GET` | [Return an
AdvancedDataTypeResponse](./api/return-an-advanceddatatyperesponse) |
`/api/v1/advanced_data_type/convert` |
+| `GET` | [Return an
AdvancedDataTypeResponse](./api/return-an-advanced-data-type-response) |
`/api/v1/advanced_data_type/convert` |
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incorrect hyphenation of class name</b></div>
<div id="fix">
Hyphenating 'AdvancedDataTypeResponse' to 'Advanced Data Type Response'
breaks the standard naming convention for class names.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- a/docs/developer_docs/api.mdx
+++ b/docs/developer_docs/api.mdx
@@ -252,1 +252,1 @@
-| `GET` | [Return an
AdvancedDataTypeResponse](./api/return-an-advanced-data-type-response) |
`/api/v1/advanced_data_type/convert` |
+| `GET` | [Return an
AdvancedDataTypeResponse](./api/return-an-advanceddatatyperesponse) |
`/api/v1/advanced_data_type/convert` |
```
</div>
</details>
</div>
<small><i>Code Review Run #b9726a</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
docs/developer_docs/components/ui/tabs.mdx:
##########
@@ -212,7 +212,7 @@ function IconTabs() {
## Import
```tsx
-import { Tabs } from '@superset/components';
+import Tabs from '@superset/components';
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incorrect Import Path in Docs</b></div>
<div id="fix">
The import path '@superset/components' does not exist in the codebase. The
Tabs component is exported from '@superset-ui/core/components', so the import
should be updated accordingly.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
import Tabs from '@superset-ui/core/components';
````
</div>
</details>
</div>
<details>
<summary><b>Citations</b></summary>
<ul>
<li>
Rule Violated: <a
href="https://github.com/apache/superset/blob/a6a93cd/AGENTS.md#L33";>AGENTS.md:33</a>
</li>
</ul>
</details>
<small><i>Code Review Run #b9726a</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
docs/developer_docs/api.mdx:
##########
@@ -84,7 +84,7 @@ curl -H "Authorization: Bearer YOUR_ACCESS_TOKEN" \
| `POST` | [Mark the dashboard as favorite for the current
user](./api/mark-the-dashboard-as-favorite-for-the-current-user) |
`/api/v1/dashboard/{pk}/favorites/` |
| `PUT` | [Update native filters configuration for a
dashboard.](./api/update-native-filters-configuration-for-a-dashboard) |
`/api/v1/dashboard/{pk}/filters` |
| `GET` | [Get a computed screenshot from cache
(dashboard-pk-screenshot-digest)](./api/get-a-computed-screenshot-from-cache-dashboard-pk-screenshot-digest)
| `/api/v1/dashboard/{pk}/screenshot/{digest}/` |
-| `GET` | [Get dashboard's thumbnail](./api/get-dashboard-s-thumbnail) |
`/api/v1/dashboard/{pk}/thumbnail/{digest}/` |
+| `GET` | [Get dashboard's thumbnail](./api/get-dashboards-thumbnail) |
`/api/v1/dashboard/{pk}/thumbnail/{digest}/` |
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Broken documentation link</b></div>
<div id="fix">
The link points to a non-existent file, which will result in broken
documentation navigation.
</div>
</div>
<small><i>Code Review Run #b9726a</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
docs/developer_docs/api.mdx:
##########
@@ -68,14 +68,14 @@ curl -H "Authorization: Bearer YOUR_ACCESS_TOKEN" \
| `POST` | [Create a new dashboard](./api/create-a-new-dashboard) |
`/api/v1/dashboard/` |
| `GET` | [Get metadata information about this API resource
(dashboard--info)](./api/get-metadata-information-about-this-api-resource-dashboard-info)
| `/api/v1/dashboard/_info` |
| `GET` | [Get a dashboard detail
information](./api/get-a-dashboard-detail-information) |
`/api/v1/dashboard/{id_or_slug}` |
-| `GET` | [Get a dashboard's chart
definitions.](./api/get-a-dashboard-s-chart-definitions) |
`/api/v1/dashboard/{id_or_slug}/charts` |
+| `GET` | [Get a dashboard's chart
definitions.](./api/get-a-dashboards-chart-definitions) |
`/api/v1/dashboard/{id_or_slug}/charts` |
| `POST` | [Create a copy of an existing
dashboard](./api/create-a-copy-of-an-existing-dashboard) |
`/api/v1/dashboard/{id_or_slug}/copy/` |
-| `GET` | [Get dashboard's datasets](./api/get-dashboard-s-datasets) |
`/api/v1/dashboard/{id_or_slug}/datasets` |
-| `DELETE` | [Delete a dashboard's embedded
configuration](./api/delete-a-dashboard-s-embedded-configuration) |
`/api/v1/dashboard/{id_or_slug}/embedded` |
-| `GET` | [Get the dashboard's embedded
configuration](./api/get-the-dashboard-s-embedded-configuration) |
`/api/v1/dashboard/{id_or_slug}/embedded` |
-| `POST` | [Set a dashboard's embedded
configuration](./api/set-a-dashboard-s-embedded-configuration) |
`/api/v1/dashboard/{id_or_slug}/embedded` |
+| `GET` | [Get dashboard's datasets](./api/get-dashboards-datasets) |
`/api/v1/dashboard/{id_or_slug}/datasets` |
+| `DELETE` | [Delete a dashboard's embedded
configuration](./api/delete-a-dashboards-embedded-configuration) |
`/api/v1/dashboard/{id_or_slug}/embedded` |
+| `GET` | [Get the dashboard's embedded
configuration](./api/get-the-dashboards-embedded-configuration) |
`/api/v1/dashboard/{id_or_slug}/embedded` |
+| `POST` | [Set a dashboard's embedded
configuration](./api/set-a-dashboards-embedded-configuration) |
`/api/v1/dashboard/{id_or_slug}/embedded` |
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Broken documentation link</b></div>
<div id="fix">
The link points to a non-existent file, which will result in broken
documentation navigation.
</div>
</div>
<small><i>Code Review Run #b9726a</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
docs/developer_docs/api.mdx:
##########
@@ -324,8 +324,8 @@ curl -H "Authorization: Bearer YOUR_ACCESS_TOKEN" \
| Method | Endpoint | Description |
|--------|----------|-------------|
-| `POST` | [Create a new dashboard's permanent
link](./api/create-a-new-dashboard-s-permanent-link) |
`/api/v1/dashboard/{pk}/permalink` |
-| `GET` | [Get dashboard's permanent link
state](./api/get-dashboard-s-permanent-link-state) |
`/api/v1/dashboard/permalink/{key}` |
+| `POST` | [Create a new dashboard's permanent
link](./api/create-a-new-dashboards-permanent-link) |
`/api/v1/dashboard/{pk}/permalink` |
+| `GET` | [Get dashboard's permanent link
state](./api/get-dashboards-permanent-link-state) |
`/api/v1/dashboard/permalink/{key}` |
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Broken documentation link</b></div>
<div id="fix">
The link points to a non-existent file, which will result in broken
documentation navigation.
</div>
</div>
<small><i>Code Review Run #b9726a</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
docs/developer_docs/api.mdx:
##########
@@ -68,14 +68,14 @@ curl -H "Authorization: Bearer YOUR_ACCESS_TOKEN" \
| `POST` | [Create a new dashboard](./api/create-a-new-dashboard) |
`/api/v1/dashboard/` |
| `GET` | [Get metadata information about this API resource
(dashboard--info)](./api/get-metadata-information-about-this-api-resource-dashboard-info)
| `/api/v1/dashboard/_info` |
| `GET` | [Get a dashboard detail
information](./api/get-a-dashboard-detail-information) |
`/api/v1/dashboard/{id_or_slug}` |
-| `GET` | [Get a dashboard's chart
definitions.](./api/get-a-dashboard-s-chart-definitions) |
`/api/v1/dashboard/{id_or_slug}/charts` |
+| `GET` | [Get a dashboard's chart
definitions.](./api/get-a-dashboards-chart-definitions) |
`/api/v1/dashboard/{id_or_slug}/charts` |
| `POST` | [Create a copy of an existing
dashboard](./api/create-a-copy-of-an-existing-dashboard) |
`/api/v1/dashboard/{id_or_slug}/copy/` |
-| `GET` | [Get dashboard's datasets](./api/get-dashboard-s-datasets) |
`/api/v1/dashboard/{id_or_slug}/datasets` |
-| `DELETE` | [Delete a dashboard's embedded
configuration](./api/delete-a-dashboard-s-embedded-configuration) |
`/api/v1/dashboard/{id_or_slug}/embedded` |
-| `GET` | [Get the dashboard's embedded
configuration](./api/get-the-dashboard-s-embedded-configuration) |
`/api/v1/dashboard/{id_or_slug}/embedded` |
-| `POST` | [Set a dashboard's embedded
configuration](./api/set-a-dashboard-s-embedded-configuration) |
`/api/v1/dashboard/{id_or_slug}/embedded` |
+| `GET` | [Get dashboard's datasets](./api/get-dashboards-datasets) |
`/api/v1/dashboard/{id_or_slug}/datasets` |
+| `DELETE` | [Delete a dashboard's embedded
configuration](./api/delete-a-dashboards-embedded-configuration) |
`/api/v1/dashboard/{id_or_slug}/embedded` |
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Broken documentation link</b></div>
<div id="fix">
The link points to a non-existent file, which will result in broken
documentation navigation.
</div>
</div>
<small><i>Code Review Run #b9726a</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
docs/developer_docs/api.mdx:
##########
@@ -324,8 +324,8 @@ curl -H "Authorization: Bearer YOUR_ACCESS_TOKEN" \
| Method | Endpoint | Description |
|--------|----------|-------------|
-| `POST` | [Create a new dashboard's permanent
link](./api/create-a-new-dashboard-s-permanent-link) |
`/api/v1/dashboard/{pk}/permalink` |
-| `GET` | [Get dashboard's permanent link
state](./api/get-dashboard-s-permanent-link-state) |
`/api/v1/dashboard/permalink/{key}` |
+| `POST` | [Create a new dashboard's permanent
link](./api/create-a-new-dashboards-permanent-link) |
`/api/v1/dashboard/{pk}/permalink` |
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Broken documentation link</b></div>
<div id="fix">
The link points to a non-existent file, which will result in broken
documentation navigation.
</div>
</div>
<small><i>Code Review Run #b9726a</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
docs/developer_docs/api.mdx:
##########
@@ -335,7 +335,7 @@ curl -H "Authorization: Bearer YOUR_ACCESS_TOKEN" \
| Method | Endpoint | Description |
|--------|----------|-------------|
| `POST` | [Create a new permanent link
(explore-permalink)](./api/create-a-new-permanent-link-explore-permalink) |
`/api/v1/explore/permalink` |
-| `GET` | [Get chart's permanent link
state](./api/get-chart-s-permanent-link-state) |
`/api/v1/explore/permalink/{key}` |
+| `GET` | [Get chart's permanent link
state](./api/get-charts-permanent-link-state) |
`/api/v1/explore/permalink/{key}` |
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Broken documentation link</b></div>
<div id="fix">
The link points to a non-existent file, which will result in broken
documentation navigation.
</div>
</div>
<small><i>Code Review Run #b9726a</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
docs/developer_docs/components/ui/tablecollection.mdx:
##########
@@ -55,7 +55,7 @@ function Demo() {
## Import
```tsx
-import { TableCollection } from '@superset/components';
+import TableCollection from '@superset/components';
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incorrect import path causes runtime error</b></div>
<div id="fix">
The import path '@superset/components' does not export TableCollection, as
confirmed by checking the components index.ts file. This will result in a
runtime error if users copy this code. The correct import, used elsewhere in
the codebase, is from '@superset-ui/core/components/TableCollection'.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
import TableCollection from '@superset-ui/core/components/TableCollection';
````
</div>
</details>
</div>
<small><i>Code Review Run #b9726a</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
docs/developer_docs/components/ui/tree.mdx:
##########
@@ -257,7 +257,7 @@ function LinesAndIcons() {
## Import
```tsx
-import { Tree } from '@superset/components';
+import Tree from '@superset/components';
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incorrect import path in documentation</b></div>
<div id="fix">
The import path '@superset/components' does not exist in the codebase.
According to the development standards in .cursor/rules/dev-standard.mdc and
AGENTS.md, UI components should be imported from
'@superset-ui/core/components'. The Tree component is properly exported as
default from this path.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
import Tree from '@superset-ui/core/components';
````
</div>
</details>
</div>
<details>
<summary><b>Citations</b></summary>
<ul>
<li>
Rule Violated: <a
href="https://github.com/apache/superset/blob/a6a93cd/.cursor/rules/dev-standard.mdc#L37";>dev-standard.mdc:37</a>
</li>
<li>
Rule Violated: <a
href="https://github.com/apache/superset/blob/a6a93cd/AGENTS.md#L33";>AGENTS.md:33</a>
</li>
</ul>
</details>
<small><i>Code Review Run #b9726a</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
