LevisNgigi commented on code in PR #38524:
URL: https://github.com/apache/superset/pull/38524#discussion_r2909968963
##########
superset-frontend/src/dashboard/components/gridComponents/Tab/Tab.tsx:
##########
@@ -446,7 +446,7 @@ const Tab = (props: TabProps): ReactElement => {
title={component.meta.text}
defaultTitle={component.meta.defaultText}
placeholder={component.meta.placeholder}
- canEdit={editMode && isFocused}
+ canEdit={editMode}
onSaveTitle={handleChangeText}
showTooltip={false}
editing={editMode && isFocused}
Review Comment:
The behavior is intentional.
canEdit={editMode} enables the editable title layout for all tabs in edit
mode, which fixes a visual issue where new tab underlines don’t span the full
width.
editing={editMode && isFocused} still ensures that only the focused tab is
actively edited.
Reverting canEdit to depend on focus would reintroduce the original tab
underline bug, so the current logic is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
