bito-code-review[bot] commented on code in PR #38524:
URL: https://github.com/apache/superset/pull/38524#discussion_r2909974036
##########
superset-frontend/src/dashboard/components/gridComponents/Tab/Tab.tsx:
##########
@@ -446,7 +446,7 @@ const Tab = (props: TabProps): ReactElement => {
title={component.meta.text}
defaultTitle={component.meta.defaultText}
placeholder={component.meta.placeholder}
- canEdit={editMode && isFocused}
+ canEdit={editMode}
onSaveTitle={handleChangeText}
showTooltip={false}
editing={editMode && isFocused}
Review Comment:
<!-- Bito Reply -->
The suggestion to revert canEdit to {editMode && isFocused} isn't fully
correct — it would reintroduce the tab underline width bug by preventing
editable layout on unfocused tabs, as the current logic (canEdit={editMode})
fixes this while keeping editing focused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
