Antonio-RiveroMartnez commented on code in PR #38405: URL: https://github.com/apache/superset/pull/38405#discussion_r2910732233
########## superset/mcp_service/chart/viz_type_names.py: ########## @@ -0,0 +1,146 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: Is it anyway we can leverage the existing https://github.com/apache/superset/blob/master/superset-frontend/packages/superset-ui-core/src/chart/types/VizType.ts ? (I know that's `.ts`), or put somewhere that when changing that we need to also update this and viceversa. Thinking on how to get only 1 place with this mapping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
