aminghadersohi commented on code in PR #38405: URL: https://github.com/apache/superset/pull/38405#discussion_r2911389137
########## superset/mcp_service/chart/viz_type_names.py: ########## @@ -0,0 +1,146 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: Good question\! VizType.ts is a TypeScript enum in the frontend that isn't accessible from Python at runtime. The implementation already reads legacy chart display names from `BaseViz.verbose_name` at runtime. For modern frontend-only plugins (ECharts, Big Number, etc.), their readable names are defined only in TypeScript `ChartMetadata.name` — so a small `_FRONTEND_ONLY_NAMES` dict is needed. I'll add a comment in both files referencing each other to help keep them in sync. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
