bito-code-review[bot] commented on code in PR #36933:
URL: https://github.com/apache/superset/pull/36933#discussion_r2911861349
##########
superset/security/manager.py:
##########
@@ -2810,6 +2821,17 @@ def validate_guest_token_resources(resources:
GuestTokenResources) -> None:
embedded =
EmbeddedDashboardDAO.find_by_id(str(resource["id"]))
if not embedded:
raise EmbeddedDashboardNotFoundError()
+ elif resource["type"] ==
GuestTokenResourceType.CHART_PERMALINK.value:
+ # Validate that the chart permalink exists
+ permalink_key = str(resource["id"])
+ try:
+ permalink_value =
GetExplorePermalinkCommand(permalink_key).run()
+ if not permalink_value:
+ raise EmbeddedChartPermalinkNotFoundError()
+ except EmbeddedChartPermalinkNotFoundError:
+ raise
+ except (ExplorePermalinkGetFailedError, ValueError) as ex:
+ raise EmbeddedChartPermalinkNotFoundError() from ex
Review Comment:
<!-- Bito Reply -->
The exception handling is correctly designed to propagate access denials
like ChartAccessDeniedError while converting only genuine lookup failures
(ExplorePermalinkGetFailedError, ValueError) to 'not found' errors, preventing
security issues from masking access restrictions.
**superset/security/manager.py**
```
elif resource["type"] == GuestTokenResourceType.CHART_PERMALINK.value:
# Validate that the chart permalink exists
permalink_key = str(resource["id"])
try:
permalink_value =
GetExplorePermalinkCommand(permalink_key).run()
if not permalink_value:
raise EmbeddedChartPermalinkNotFoundError()
except EmbeddedChartPermalinkNotFoundError:
raise
except (ExplorePermalinkGetFailedError, ValueError) as ex:
raise EmbeddedChartPermalinkNotFoundError() from ex
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
