bito-code-review[bot] commented on code in PR #36933: URL: https://github.com/apache/superset/pull/36933#discussion_r2911880946
########## superset/embedded_chart/exceptions.py: ########## @@ -0,0 +1,35 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from superset.exceptions import SupersetException + + +class EmbeddedChartPermalinkNotFoundError(SupersetException): + """Raised when an embedded chart permalink is not found or has expired.""" + + message = "The embedded chart permalink could not be found or has expired." Review Comment: <!-- Bito Reply --> Partially — the suggestion adds lazy_gettext for i18n and status codes to the exception classes, which improves internationalization and error handling, but the status code for EmbeddedChartAccessDeniedError should be 401 instead of 403 to match standard HTTP semantics for unauthorized access. **superset/embedded_chart/exceptions.py** ``` from flask_babel import lazy_gettext as _ from superset.exceptions import SupersetException class EmbeddedChartPermalinkNotFoundError(SupersetException): """Raised when an embedded chart permalink is not found or has expired.""" status = 404 message = _("The embedded chart permalink could not be found or has expired.") class EmbeddedChartAccessDeniedError(SupersetException): """Raised when access to an embedded chart is denied.""" status = 401 message = _("Access to this embedded chart is denied.") class EmbeddedChartFeatureDisabledError(SupersetException): """Raised when the embeddable charts feature is disabled.""" status = 403 message = _("The embeddable charts feature is not enabled.") ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
