bito-code-review[bot] commented on code in PR #38369:
URL: https://github.com/apache/superset/pull/38369#discussion_r2917139803
##########
superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTableChart.tsx:
##########
@@ -187,6 +188,7 @@ export default function TableChart<D extends DataRecord =
DataRecord>(
lastFilteredColumn: completeFilterState.lastFilteredColumn,
lastFilteredInputPosition: completeFilterState.inputPosition,
currentPage: 0, // Reset to first page when filtering
+ metricSqlExpressions,
Review Comment:
<!-- Bito Reply -->
Yes, adding `metricSqlExpressions` to the state reset is relevant—it
preserves metric SQL expressions during filtering, enabling the new
label-to-SQL resolution feature in the query builder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
