bito-code-review[bot] commented on PR #38602: URL: https://github.com/apache/superset/pull/38602#issuecomment-4047973937
<!-- Bito Reply --> Changing color factories to always return a color would eliminate the need for null handling here, simplifying the code. Using `colorPrimary` instead of `colorBorder` makes sense semantically for the main fill color, assuming `colorPrimary` is defined in the theme. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
