rebenitez1802 commented on code in PR #38602:
URL: https://github.com/apache/superset/pull/38602#discussion_r2926101975
##########
superset-frontend/plugins/legacy-plugin-chart-world-map/src/WorldMap.ts:
##########
@@ -157,7 +157,7 @@ function WorldMap(element: HTMLElement, props:
WorldMapProps): void {
processedData = filteredData.map(d => ({
...d,
radius: radiusScale(Math.sqrt(d.m2)),
- fillColor: colorFn(d.m1),
+ fillColor: colorFn(d.m1) ?? theme.colorBorder,
Review Comment:
Agree on the factory part.
but we use `colorBorder` as default because is already set as `defaultFill`
in
https://github.com/apache/superset/blob/master/superset-frontend/plugins/legacy-plugin-chart-world-map/src/WorldMap.ts#L262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
