aminghadersohi commented on code in PR #38277:
URL: https://github.com/apache/superset/pull/38277#discussion_r2930382639
##########
superset/mcp_service/dashboard/tool/generate_dashboard.py:
##########
@@ -295,7 +296,10 @@ def generate_dashboard(
if serialize_tag_object(tag) is not None
],
roles=[], # Dashboard roles not typically set at creation
- charts=[], # Chart details not needed in response
+ charts=[
+ serialize_chart_object(chart)
+ for chart in getattr(dashboard, "slices", [])
+ ],
Review Comment:
Good catch — fixed. The charts list now filters out None values from
serialize_chart_object. See latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
