bito-code-review[bot] commented on code in PR #36933:
URL: https://github.com/apache/superset/pull/36933#discussion_r2932182158
##########
tests/unit_tests/extensions/test_types.py:
##########
@@ -61,6 +61,18 @@ def test_extension_config_full():
"description": "A query insights extension",
"dependencies": ["other-extension"],
"permissions": ["can_read", "can_view"],
+ "frontend": {
+ "contributions": {
+ "views": {
+ "sqllab": {
+ "panels": [
+ {"id": "query_insights.main", "name": "Query
Insights"}
+ ]
+ }
+ }
+ },
+ "moduleFederation": {"exposes": ["./index"]},
+ },
Review Comment:
<!-- Bito Reply -->
No, the suggestion isn’t fully correct — because the ExtensionConfig model
does not define a frontend field, so accessing config.frontend will raise an
AttributeError, causing the test to fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
