bito-code-review[bot] commented on code in PR #34629:
URL: https://github.com/apache/superset/pull/34629#discussion_r2932761061
##########
superset-frontend/packages/superset-ui-core/src/components/ListViewCard/index.tsx:
##########
@@ -95,7 +95,6 @@ const TitleLink = styled.span`
const TitleRight = styled.span`
${({ theme }) => css`
position: absolute;
- right: -1px;
font-weight: 400;
bottom: ${theme.sizeUnit * 3}px;
right: ${theme.sizeUnit * 2}px;
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>RTL Layout Broken</b></div>
<div id="fix">
This change hardcodes the TitleRight element to 'right' positioning,
breaking RTL (right-to-left) language support. In RTL layouts, the element
should appear on the left side. The original code correctly used
theme.direction to set 'left' for RTL and 'right' for LTR. Restoring this
ensures proper positioning across languages.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
bottom: ${theme.sizeUnit * 3}px;
${theme.direction === 'rtl'
? `left: ${theme.sizeUnit * 2}px;`
: `right: ${theme.sizeUnit * 2}px;`}
`}
````
</div>
</details>
</div>
<small><i>Code Review Run #7da198</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
