manojshetty2004 opened a new pull request, #38657:
URL: https://github.com/apache/superset/pull/38657

   ### SUMMARY
   This change makes the `dataZoom` slider bottom offset responsive to the 
chart height in ECharts time-series charts.
   
   Previously, the slider used a fixed offset:
   
   TIMESERIES_CONSTANTS.zoomBottom
   
   In smaller chart panels or dashboards with limited height, this could cause 
the zoom slider to appear clipped or overflow outside the visible chart area.
   
   This PR replaces the fixed offset with a responsive calculation based on the 
chart height:
   
   Math.max(TIMESERIES_CONSTANTS.zoomBottom, Math.floor(height * 0.08))
   
   This ensures:
   - The zoom slider keeps the existing minimum spacing.
   - The control adapts to smaller panel heights.
   - The zoom control remains visible and correctly positioned.
   
   ---
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   The zoom slider could overflow or appear clipped when the chart panel height 
is small.
   
   After:
   The zoom slider position adjusts dynamically based on chart height and 
remains visible.
   
   ---
   
   ### TESTING INSTRUCTIONS
   1. Run Superset locally.
   2. Open **Explore → ECharts Time-series chart**.
   3. Enable **Zoomable**.
   4. Reduce the chart height or place the chart in a smaller dashboard panel.
   5. Verify that the zoom slider remains visible and positioned correctly.
   
   ---
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: Fixes #37286
   - [ ] Required feature flags
   - [x] Changes UI
   - [ ] Includes DB Migration
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to