bito-code-review[bot] commented on code in PR #38657:
URL: https://github.com/apache/superset/pull/38657#discussion_r2936953905
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts:
##########
@@ -799,6 +799,11 @@ export default function transformProps(
}
}
+ const dynamicZoomBottom = Math.max(
+ TIMESERIES_CONSTANTS.zoomBottom,
+ Math.floor(height * 0.08),
+ );
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Inconsistent zoom bottom across charts</b></div>
<div id="fix">
The change introduces a dynamic zoom bottom calculation for Timeseries
charts based on height, but Gantt and MixedTimeseries charts still use the
fixed TIMESERIES_CONSTANTS.zoomBottom value. This creates inconsistency in zoom
control positioning across different chart types, potentially leading to a
confusing user experience. Consider applying the same dynamic calculation to
other chart types for consistency.
</div>
</div>
<small><i>Code Review Run #eb5663</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
