lucapazz commented on PR #38094: URL: https://github.com/apache/superset/pull/38094#issuecomment-4066880665
> > @EnxDev let me know if you think I should update or improve anything else. Thanks! > > Hey @lucapazz this branch should also be rebased onto the base branch (master), also Superset uses Git pre-commit hooks courtesy of pre-commit. To install run the following: > > `pre-commit install ` > > This will install the hooks in your local repository. From now on, a series of checks will automatically run whenever you make a Git commit. To run pre-commit manually run the following: > > `pre-commit run --all-files` Hey @EnxDev, thank you for the guidance. Regarding the pre-commit hooks, I have actually had them installed and active since the beginning of my work, and they have been running on every commit I made. However, I am encountering some issues when running them against the entire codebase: some hooks (specifically `type-checking-frontend` and `pylint`) are failing with errors occurring in files that I haven't touched. Is it possible that some recent merges into the master branch bypassed the pre-commit checks, or is there a specific baseline I should be aware of? Since these errors are blocking the PR but don't seem related to my specific changes, could you provide some guidance on how to proceed? Should I attempt to fix these unrelated issues, or is there a way to run the hooks only on my staged changes to avoid "noise" from the rest of the repo? Thanks in advance for your help! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
