hainenber commented on code in PR #38635:
URL: https://github.com/apache/superset/pull/38635#discussion_r2970862978
##########
superset-frontend/packages/superset-ui-core/src/components/AsyncAceEditor/useJsonValidation.test.ts:
##########
@@ -60,7 +60,7 @@ describe('useJsonValidation', () => {
expect(result.current[0]).toMatchObject({
type: 'error',
row: 0,
- column: 0,
+ column: 1,
Review Comment:
This is intentional as Node v22 provides more details for `JSON.parse()`
error, namely the line and column data ([V8's
issue](https://issues.chromium.org/issues/42209808)).
Credit to Gemini for helping me gathering these data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
