bito-code-review[bot] commented on code in PR #38402:
URL: https://github.com/apache/superset/pull/38402#discussion_r2980543410
##########
superset/mcp_service/chart/schemas.py:
##########
@@ -590,6 +590,108 @@ class MixedTimeseriesChartConfig(BaseModel):
filters: List[FilterConfig] | None = None
+class HandlebarsChartConfig(BaseModel):
Review Comment:
<!-- Bito Reply -->
Your reasoning is valid. The schema should enforce structure and size
limits, while XSS sanitization is properly handled by Superset's
HandlebarsRenderer at the rendering layer to avoid duplication and potential
rejection of valid syntax.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
