joaopedroab commented on code in PR #38865:
URL: https://github.com/apache/superset/pull/38865#discussion_r3018922841
##########
superset-frontend/src/dataMask/reducer.ts:
##########
@@ -245,35 +246,39 @@ const dataMaskReducer = produce(
if (!isChartCustomizationItem(item)) {
return;
}
+ if (isDynamicTitleCustomization(item)) {
+ return;
+ }
+ const customizationItem = item as ChartCustomization;
- const customizationFilterId = item.id;
+ const customizationFilterId = customizationItem.id;
const dataMask = loadedDataMask || {};
cleanState[customizationFilterId] = {
...getInitialDataMask(customizationFilterId),
- ...item.defaultDataMask,
+ ...customizationItem.defaultDataMask,
...dataMask[customizationFilterId],
};
if (
draft[customizationFilterId] &&
- item.defaultDataMask &&
+ customizationItem.defaultDataMask &&
!areObjectsEqual(
- item.defaultDataMask,
+ customizationItem.defaultDataMask,
draft[customizationFilterId],
{ ignoreUndefined: true },
)
) {
cleanState[customizationFilterId] = {
...cleanState[customizationFilterId],
- ...item.defaultDataMask,
+ ...customizationItem.defaultDataMask,
};
}
Review Comment:
This is a false positive. The bot references an `if` block that compares
`customizationItem.defaultDataMask` to `draft[customizationFilterId]`, but no
such comparison exists in the code. The reducer simply spreads values in
priority order: `getInitialDataMask → defaultDataMask → loadedDataMask` (lines
257-261), which correctly prioritizes persisted state over defaults. There is
no equality check that could "almost always evaluate as not equal".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
