joaopedroab commented on code in PR #38865:
URL: https://github.com/apache/superset/pull/38865#discussion_r3018923530
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx:
##########
@@ -722,6 +898,350 @@ const FiltersConfigForm = (
const DateFilterComponent = DateFilterControlExtension ?? DateFilterControl;
+ const getDynamicTitleScopeCandidate = useCallback(
+ (customizationId: string): DynamicTitleScopeCandidate | undefined => {
+ if (removedFilters[customizationId]) {
+ return undefined;
+ }
Review Comment:
Acknowledged — this is a valid refactoring suggestion for a follow-up.
Keeping the scope of this PR focused on the feature implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
