alexandrusoare opened a new pull request, #39005:
URL: https://github.com/apache/superset/pull/39005

   ### SUMMARY
   
   Fixed the "Select all" and "Clear" buttons being clipped/cut off in 
multi-select filter dropdowns, particularly visible in the horizontal filter 
bar orientation.
   
   **Changes:**
   
   - Removed fixed gap and adjusted padding in the bulk actions container
   - Reset the automatic margin-left that the Button component adds to 
consecutive buttons
   - Removed inner padding on the buttons to maximize available space
   - Changed justify alignment to `space-between` for better distribution
   - Added smart number formatting for the counts (e.g., 1,234,567 → 1.23M) to 
handle very large datasets
   
   **Unrelated bug found:** When you deselect items in a filter and click on it 
again, if you previously had items selected, the dropdown gets resized but the 
popup retains its original width, making the popup wider than the select input. 
This is a separate issue and not addressed in this PR.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   #### AFTER
   <img width="189" height="361" alt="image" 
src="https://github.com/user-attachments/assets/255377d8-ba2f-447a-8c47-578317aee7d5";
 />
   <img width="175" height="350" alt="image" 
src="https://github.com/user-attachments/assets/3ce94544-e0e8-4e16-aefb-709c4bed874d";
 />
   <img width="333" height="481" alt="image" 
src="https://github.com/user-attachments/assets/00a83dfd-66fb-4248-9789-1acf54d8f52c";
 />
   <img width="257" height="378" alt="image" 
src="https://github.com/user-attachments/assets/acdd0cc0-548c-4e7e-85eb-7857a1773661";
 />
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to