msyavuz commented on code in PR #39005:
URL: https://github.com/apache/superset/pull/39005#discussion_r3021938161
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.tsx:
##########
@@ -873,7 +873,9 @@ export class TableRenderer extends Component<
);
};
const headerCellFormattedValue =
-
dateFormatters?.[attrName]?.(convertToNumberIfNumeric(colKey[attrIdx])) ??
colKey[attrIdx];
+ dateFormatters?.[attrName]?.(
+ convertToNumberIfNumeric(colKey[attrIdx]),
+ ) ?? colKey[attrIdx];
Review Comment:
I've seen these formattings on other pr's as well. What is happening and why
are unrelated files being formatted on some pr's?
##########
superset-frontend/packages/superset-ui-core/src/components/Select/styles.tsx:
##########
@@ -140,11 +140,17 @@ export const StyledErrorMessage = styled.div`
export const StyledBulkActionsContainer = styled(Flex)`
${({ theme }) => `
- padding: ${theme.sizeUnit}px;
+ padding: ${theme.sizeUnit}px 0;
border-top: 1px solid ${theme.colorSplit};
- gap: ${theme.sizeUnit * 2}px;
& .superset-button {
font-family: inherit;
+ margin-left: 0 !important;
+ }
+ & .superset-button:first-of-type {
+ padding-right: 0 !important;
+ }
+ & .superset-button:last-of-type {
+ padding-left: 0 !important;
Review Comment:
Do we need these !important?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
