codecov-io edited a comment on issue #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#issuecomment-525919765 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr&el=h1) Report > Merging [#8138](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6aa10dc016455728c7da4dfabd849c59dc9f7f66?src=pr&el=desc) will **decrease** coverage by `7.59%`. > The diff coverage is `98.22%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #8138 +/- ## ========================================== - Coverage 73.71% 66.11% -7.6% ========================================== Files 115 486 +371 Lines 12059 23135 +11076 Branches 0 2541 +2541 ========================================== + Hits 8889 15296 +6407 - Misses 3170 7705 +4535 - Partials 0 134 +134 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.38% <100%> (+0.72%)` | :arrow_up: | | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `50% <100%> (+22.22%)` | :arrow_up: | | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.99% <100%> (+0.94%)` | :arrow_up: | | [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `86.36% <85.71%> (-1.52%)` | :arrow_down: | | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `25.95% <94.44%> (+4.35%)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.86% <98.52%> (+0.48%)` | :arrow_up: | | [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | `100% <0%> (ø)` | | | [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz) | `0% <0%> (ø)` | | | [.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==) | `88.23% <0%> (ø)` | | | [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | `94.59% <0%> (ø)` | | | ... and [369 more](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr&el=footer). Last update [6aa10dc...4b50c18](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
