codecov-io edited a comment on issue #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#issuecomment-525919765 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr&el=h1) Report > Merging [#8138](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/be33934b838f9fae097882d401c9473bfc2d124c?src=pr&el=desc) will **increase** coverage by `0.03%`. > The diff coverage is `92.53%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #8138 +/- ## ========================================== + Coverage 66.18% 66.21% +0.03% ========================================== Files 479 479 Lines 22931 23035 +104 Branches 2524 2524 ========================================== + Hits 15176 15252 +76 - Misses 7621 7649 +28 Partials 134 134 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `67.74% <33.33%> (ø)` | :arrow_up: | | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `50% <80%> (+22.22%)` | :arrow_up: | | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `25.95% <85%> (+4.35%)` | :arrow_up: | | [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `86.36% <85.71%> (-1.52%)` | :arrow_down: | | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.52% <95.12%> (+0.46%)` | :arrow_up: | | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.31% <96.47%> (+0.65%)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.96% <98.11%> (+0.7%)` | :arrow_up: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `43.13% <0%> (-49.02%)` | :arrow_down: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.12% <0%> (-0.65%)` | :arrow_down: | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.29% <0%> (-0.22%)` | :arrow_down: | | ... and [1 more](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr&el=footer). Last update [be33934...e2b2ace](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
