Copilot commented on code in PR #39295:
URL: https://github.com/apache/superset/pull/39295#discussion_r3190458229
##########
superset-frontend/src/components/Chart/DrillDetail/DrillDetailPane.tsx:
##########
@@ -314,6 +314,7 @@ export default function DrillDetailPane({
columns={mappedColumns}
size={TableSize.Small}
defaultPageSize={PAGE_SIZE}
+ pageSizeOptions={[`${PAGE_SIZE}`]}
Review Comment:
This change modifies visible pagination behavior (the page-size selector
options) but doesn’t appear to add a regression test for it. Since
DrillDetailPane already has tests per the PR description, add/extend a test to
assert the page size selector only offers the fixed PAGE_SIZE (and that
selecting other sizes is not possible). This will prevent reintroducing the
UI/backend mismatch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
