bito-code-review[bot] commented on PR #39295: URL: https://github.com/apache/superset/pull/39295#issuecomment-4381684795
<!-- Bito Reply --> The change adds pageSizeOptions to fix the selector to only show the fixed PAGE_SIZE. To add a regression test, extend the existing DrillDetailPane test file (likely DrillDetailPane.test.tsx) with a test that renders the component and asserts the page size selector options are limited to [PAGE_SIZE], and that selecting other sizes isn't possible (e.g., by checking the select element's options and simulating user interaction). However, since the test file isn't in the provided PR context, I can't generate the exact code snippet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
