bito-code-review[bot] commented on PR #39345:
URL: https://github.com/apache/superset/pull/39345#issuecomment-4381716726
<!-- Bito Reply -->
Yes, the suggestion is valid — it fixes the regression by ensuring
ENTIRE_ROW is always available, even with zero columns, restoring the previous
behavior that only required array presence.
**superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx**
```
const allColumns = [
{
value: ObjectFormattingEnum.ENTIRE_ROW,
label: t('entire row'),
dataType: GenericDataType.String,
},
...(hasColumns
? colnames.map((colname: string, index: number) => ({
value: colname,
label: Array.isArray(verboseMap)
? colname
: (verboseMap[colname] ?? colname),
dataType: coltypes[index],
}))
: []),
];
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
