mistercrunch commented on PR #39345: URL: https://github.com/apache/superset/pull/39345#issuecomment-4399540651
@aminghadersohi thanks for the review! Both nits are addressed in 3a75879: 1. **File modes** — reverted `controlPanel.tsx` and `controlPanel.test.tsx` from `100755` back to `100644`. 2. **ENTIRE_ROW test gap** — added an explicit test (`allColumns includes ENTIRE_ROW when falling back to datasource columns`) that asserts `ENTIRE_ROW` is present in `allColumns` when the query response is empty and we're using the datasource fallback. The other empty-state branch (`columnOptions returns empty when both queriesResponse and datasource have no columns`) covers the case where `hasColumns` is false and `ENTIRE_ROW` correctly drops out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
