villebro commented on issue #39642: URL: https://github.com/apache/superset/issues/39642#issuecomment-4382449076
Thanks for the great proposal @Vitor-Avila ! Some thoughts: - Rather than introduce a new table for A&R specific configs, I think it may make sense to something similar to [SIP-127 - User Preferences](https://github.com/apache/superset/issues/28047), but expanding the scope to global configs. The need for this has come up with increasing frequency as of late, especially in the context of extensions. Having a dedicated table + UI for managing these would pave the way for moving more and more configs into the UI for more convenient and dynamic configuration. - When I implemented the whole `ExectutorType` system, the motivation was to introduce a backwards compatible solution that supports executing A&R and Thumbnail and cache warmup queries as an identity other than a central service account (in particular for OAuth2 E2E db auth, where the `admin` user will typically not exist or have an id/access token). However, it definitely came with a trade-off of added complexity, as can be seen by the various executor profiles and parametrized tests for the `get_executor` util. I think the **Run As** field is a good solution to address this. - The forthcoming Subject model work (See #38831) may collide with this feature, as it aims to replace most User/Role/Group specific properties with the new Subject model (where applicable). So I recommend considering waiting for that to be merged first, as it will have implications for the implementation of this. The plan is to have it land fairly soon once the breaking window for 7.0 is open. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
