EnxDev commented on code in PR #38307:
URL: https://github.com/apache/superset/pull/38307#discussion_r3191253990
##########
superset-frontend/src/dashboard/components/gridComponents/Chart/Chart.test.tsx:
##########
@@ -379,6 +370,79 @@ test('should fallback to formData state when runtime state
not available', () =>
expect(getByTestId('chart-container')).toBeInTheDocument();
});
+test('chart height is reduced on first render in expanded state (guards
against useEffect regression)', () => {
+ const DESCRIPTION_HEIGHT = 60;
+ const CHART_HEIGHT = 300;
+ // Matches the DEFAULT_HEADER_HEIGHT constant in Chart.tsx.
+ const DEFAULT_HEADER_HEIGHT = 22;
Review Comment:
Can we import it from chart?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
