sadpandajoe commented on code in PR #39423:
URL: https://github.com/apache/superset/pull/39423#discussion_r3196529470
##########
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.test.tsx:
##########
@@ -487,6 +487,42 @@ test('should render ParentSize wrapper with height 100%
for tabs', async () => {
expect(tabPanels.length).toBeGreaterThan(0);
});
+test('should apply min-height to the top-level tab drop target so tabs can be
dropped on dashboards with content', () => {
+ (useStoredSidebarWidth as jest.Mock).mockImplementation(() => [
+ 100,
+ jest.fn(),
+ ]);
+ (fetchFaveStar as jest.Mock).mockReturnValue({ type: 'mock-action' });
+ (setActiveTab as jest.Mock).mockReturnValue({ type: 'mock-action' });
+
+ const { getByTestId } = render(<DashboardBuilder />, {
+ useRedux: true,
+ store: storeWithState({
+ ...mockState,
+ dashboardLayout: undoableDashboardLayout,
+ dashboardState: { ...mockState.dashboardState, editMode: true },
+ }),
+ useDnd: true,
+ useTheme: true,
+ });
+
+ const headerWrapper = getByTestId('dashboard-header-wrapper');
+
+ // The Droppable inside the header should have the empty-droptarget class
+ // when there are no top-level tabs and edit mode is active. Without this
+ // class (and its associated min-height CSS rule), the drop target has zero
+ // height and users cannot drag tabs onto dashboards that already have
+ // content.
+ const droptarget = headerWrapper.querySelector('.empty-droptarget');
+ expect(droptarget).toBeInTheDocument();
+
+ // Verify the StyledHeader CSS defines a non-zero min-height for
+ // .empty-droptarget (theme.sizeUnit * 4 = 16px with the default theme).
+ expect(headerWrapper).toHaveStyleRule('min-height', '16px', {
Review Comment:
Fixed in `b71c556560` — switched the assertion to `${supersetTheme.sizeUnit
* 4}px` so it tracks the theme token used by the source rule.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
