gweis commented on issue #38413: URL: https://github.com/apache/superset/issues/38413#issuecomment-4392817956
Yes it's a solution, but I don't think it's a good idea to have sqlalchemy metadata defined in one ore another place. - What's the rule ... when do fields get placed into which one ? If this pattern is truly correct, then it mostly likely needs to be done in plenty of other places in superset as well. I am not trying to criticise your solution, but I am more questioning the logic inside superset if this is the correct approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
