MasMadd commented on issue #38413: URL: https://github.com/apache/superset/issues/38413#issuecomment-4395257009
> Yes it's a solution, but I don't think it's a good idea to have sqlalchemy metadata defined in one ore another place. > > * What's the rule ... when do fields get placed into which one ? > > If this pattern is truly correct, then it mostly likely needs to be done in plenty of other places in superset as well. > > I am not trying to criticise your solution, but I am more questioning the logic inside superset if this is the correct approach. > > Or the setup for the function should be fixed. How does it happen that in some environments one part is populated but in others the other one is populated ? I think consistency problems should be fixed at were it happens, and not necessarily guessing afterwards whether setup worked as usual or did something else for whatever reason. I think you're right about wanting to fix the core logic of superset, which I'm not 100% familiar with. For this reason, my proposal is limited to adding only fallback logic to the original code. If there's a similar pattern that needs to be fixed in other parts of superset, I'm not aware of it, and I wouldn't know how to fix the root problem. I ran this command during the superset bootstrap process, and I genuinely thought the problem was just a small bug in the context of superset, which wasn't fully initialized and set to run that command at a specific stage. The official documentation for that command makes no mention of the fact that the command requires superset to be started with the usual gunicorn command before being typed. Perhaps a more in-depth analysis by those who know superset better is needed (?). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
