koljaschumann commented on PR #39245:
URL: https://github.com/apache/superset/pull/39245#issuecomment-4397736483
Hi @rusackas — thanks for the review and the merge signal. Addressing your
note on bot feedback and resolving the conflict:
**Bot triage complete:**
**codeant-ai-for-open-source** (9 inline comments):
- Duplicate error IDs (TextControl, NumberControl, ControlHeader): ✅ Already
fixed in commit 9d0f14c5 — ControlHeader now accepts `errorId` prop, single
live-region per control.
- - RoleFormItems missing aria-invalid/aria-describedby: Not taken — AntD
FormItem with `rules=[{required:true}]` already sets `aria-invalid` via
FieldContext; render-prop nesting would add complexity without behavior change.
- - SSHTunnelForm whitespace-only validation bypass: ✅ Fixed in 9d0f14c5 —
value now trimmed before empty check.
- - ModalFormField cloneElement missing wrapped inputs: ✅ Fixed in 9d0f14c5
— traversal now hops through single-child wrappers.
- - AlertReportModal false validation during loading (name + owners): ✅
Fixed in 3f2a60f8 — guards on `currentAlert`.
**bito-code-review** (runs #f7d2d1, #20ee56, #38f541):
- `NumberControl` invalid id="undefined": ✅ Fixed in 9d0f14c5.
- - `ControlHeader` duplicate IDs: ✅ Fixed in 9d0f14c5.
- - Validation inconsistency post-fix (`AlertReportModal`, run #20ee56):
@Aitema-gmbh will address in next push — tracked.
- - `TextControl` duplicate error display (run #38f541): @Aitema-gmbh will
address in next push — tracked.
- - Custom CSS in SSHTunnelForm/SqlAlchemyForm error spans: @Aitema-gmbh
will address in next push — tracked.
- - Redundant `aria-required` in RoleFormItems: @Aitema-gmbh will address in
next push — tracked.
**netlify Bot**: Deploy preview ready — informational, dismissed.
Rebase/conflict resolution will be done by @Aitema-gmbh locally. Will ping
you once the next push lands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
