codeant-ai-for-open-source[bot] commented on code in PR #39245:
URL: https://github.com/apache/superset/pull/39245#discussion_r3232737310
##########
superset-frontend/src/features/roles/RoleFormItems.tsx:
##########
@@ -37,7 +37,11 @@ export const RoleNameField = () => (
label={t('Role Name')}
rules={[{ required: true, message: t('Role name is required') }]}
>
- <Input name="roleName" data-test="role-name-input" />
+ <Input
+ name="roleName"
+ data-test="role-name-input"
+ aria-required="true"
+ />
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag missing aria-invalid or aria-describedby on AntD
Form.Item-wrapped inputs when validation rules are provided; Ant Design form
context already handles the dynamic invalid state and error association. Only
suggest extra wiring when the component bypasses that form context.
**Applied to:**
- `**/*.tsx`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
