msyavuz opened a new pull request, #39968:
URL: https://github.com/apache/superset/pull/39968

   ### SUMMARY
   
   Adds a "Show row group counts" toggle to the AG Grid Table control panel, 
placed above the existing "Show summary" checkbox and gated to Aggregate query 
mode. Defaults to on (current behavior). When off, the per-group counts shown 
next to row group labels (e.g. `United States (155)`) are suppressed via AG 
Grid's `autoGroupColumnDef.cellRendererParams.suppressCount`.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before: row group labels always show `(N)` next to the group name.
   After: users can hide that count via the new toggle.
   
   ### TESTING INSTRUCTIONS
   
   1. Open an AG Grid Table chart with row groupings (drag a column into Row 
Groups in the tool panel).
   2. In the Data tab, confirm the new "Show row group counts" toggle appears 
above "Show summary".
   3. Verify it defaults to on and group rows display `(N)` next to the label.
   4. Toggle it off — counts disappear; group labels remain. Toggle back on — 
counts return.
   5. Switch to Raw Records mode and confirm the toggle is hidden.
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue: No
   - [ ] Required feature flags: None
   - [x] Changes UI — adds one checkbox to AG Grid Table Data tab
   - [ ] Includes DB Migration: No — frontend only
   - [ ] Introduces new feature or API: Minor — new form_data key 
`show_row_group_counts`
   - [ ] Removes existing feature or API: No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to