bito-code-review[bot] commented on PR #39968:
URL: https://github.com/apache/superset/pull/39968#issuecomment-4407237991
<!-- Bito Reply -->
The flagged issue is correct. The `showRowGroupCounts` setting is forwarded
unconditionally in `transformProps.ts`, causing it to persist from Aggregate
mode to Raw mode where the control is hidden, leading to suppressed counts with
no way to re-enable them in Raw mode.
To resolve, gate the value by query mode: honor the setting only in
Aggregate mode, otherwise default to `true`.
Here's the concise fix for `transformProps.ts`:
**superset-frontend/plugins/plugin-chart-ag-grid-table/src/transformProps.ts**
```
show_row_group_counts: showRowGroupCounts = true,
query_mode: queryMode,
```
**superset-frontend/plugins/plugin-chart-ag-grid-table/src/transformProps.ts**
```
showRowGroupCounts: queryMode === 'aggregate' ? showRowGroupCounts : true,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
