Aitema-gmbh commented on code in PR #39238:
URL: https://github.com/apache/superset/pull/39238#discussion_r3232353480
##########
superset-frontend/src/filters/components/Time/TimeFilterPlugin.tsx:
##########
@@ -60,9 +60,11 @@ const ControlContainer = styled.div<{
width: 100%;
}
+ /* WCAG 1.4.11: Focus indicator needs 3:1 contrast — controlOutline is too
light (low alpha).
+ Use colorPrimary for both border and shadow to ensure 3:1+ contrast. */
&:focus > div {
Review Comment:
Addressed in 810713cc — switched the selector from `&:focus > div` to
`&:focus-within > div` so the focus indicator triggers when the descendant
`DateLabel` (`role="button"` with `tabIndex={0}`) receives keyboard focus,
rather than the `tabIndex={-1}` container that never matches `:focus`.
Resolving — thanks for the catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
