Aitema-gmbh commented on PR #39238:
URL: https://github.com/apache/superset/pull/39238#issuecomment-4440504613
@rusackas the codeant inline thread on this PR is resolved (`810713cc` —
switched the selector to `:focus-within > div` so the focus ring fires when the
descendant `DateLabel` receives keyboard focus, not the `tabIndex={-1}`
container). On your broader architectural point about preferring per-component
styles over `GlobalStyles`: happy to refactor that direction if you want — it
would spread the non-text-contrast rules across the AntD-wrapper components
individually. Wanted to check direction with you before doing the spread so I
do not move things twice. Ready for re-review either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
