Aitema-gmbh commented on code in PR #39232:
URL: https://github.com/apache/superset/pull/39232#discussion_r3232565376
##########
superset-frontend/src/features/userInfo/UserInfoModal.tsx:
##########
@@ -81,7 +82,7 @@ function UserInfoModal({
label={t('Last name')}
rules={[{ required: true, message: t('Last name is required') }]}
>
- <Input name="last_name" placeholder={t("Enter the user's last name")}
/>
+ <Input name="last_name" autoComplete="family-name"
placeholder={t("Enter the user's last name")} />
Review Comment:
Addressed in 85cdffe0 — reformatted UserInfoModal last_name <Input> to
multi-line to match surrounding style. Resolving — thanks for the catch.
##########
superset-frontend/src/features/databases/DatabaseModal/SSHTunnelForm.tsx:
##########
@@ -74,6 +74,7 @@ const SSHTunnelForm = ({
<Input
name="server_address"
type="text"
+ autoComplete="off"
placeholder={t('e.g. 127.0.0.1')}
Review Comment:
Addressed in 85cdffe0 — added id="server_address" to match FormLabel htmlFor
for proper label-input association. Resolving — thanks for the catch.
##########
superset-frontend/src/features/databases/DatabaseModal/SSHTunnelForm.tsx:
##########
@@ -90,6 +91,7 @@ const SSHTunnelForm = ({
name="server_port"
placeholder={t('22')}
type="number"
+ autoComplete="off"
Review Comment:
Addressed in 85cdffe0 — added id="server_port" to match FormLabel htmlFor
for proper label-input association. Resolving — thanks for the catch.
##########
superset-frontend/src/features/databases/DatabaseModal/SSHTunnelForm.tsx:
##########
@@ -106,6 +108,7 @@ const SSHTunnelForm = ({
<Input
name="username"
type="text"
+ autoComplete="off"
Review Comment:
Addressed in 85cdffe0 — added id="username" to match FormLabel htmlFor for
proper label-input association. Resolving — thanks for the catch.
##########
superset-frontend/src/features/databases/DatabaseModal/SSHTunnelForm.tsx:
##########
@@ -153,6 +156,7 @@ const SSHTunnelForm = ({
</FormLabel>
<StyledInputPassword
Review Comment:
Addressed in 85cdffe0 — added id="password" to match FormLabel htmlFor on
StyledInputPassword for proper label-input association. Resolving — thanks for
the catch.
##########
superset-frontend/src/features/databases/DatabaseModal/SSHTunnelForm.tsx:
##########
@@ -184,6 +188,7 @@ const SSHTunnelForm = ({
</FormLabel>
<Input.TextArea
Review Comment:
Addressed in 85cdffe0 — added id="private_key" to match FormLabel htmlFor on
Input.TextArea for proper label-input association. Resolving — thanks for the
catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
