Aitema-gmbh commented on code in PR #39232:
URL: https://github.com/apache/superset/pull/39232#discussion_r3232566614
##########
superset-frontend/src/features/databases/DatabaseModal/SSHTunnelForm.tsx:
##########
@@ -201,6 +206,7 @@ const SSHTunnelForm = ({
</FormLabel>
<StyledInputPassword
Review Comment:
Addressed in 85cdffe0 — added id="private_key_password" to match FormLabel
htmlFor on StyledInputPassword for proper label-input association. Resolving —
thanks for the catch.
##########
superset-frontend/src/features/users/UserListModal.tsx:
##########
@@ -187,7 +190,7 @@ function UserListModal({
},
]}
>
- <Input name="email" placeholder={t("Enter the user's email")} />
+ <Input name="email" autoComplete="email" placeholder={t("Enter the
user's email")} />
Review Comment:
Addressed in 85cdffe0 — reformatted UserListModal email <Input> to
multi-line to match surrounding style. Resolving — thanks for the catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
