Aitema-gmbh commented on code in PR #39235:
URL: https://github.com/apache/superset/pull/39235#discussion_r3232670773
##########
superset-frontend/src/explore/components/controls/TextControl/index.tsx:
##########
@@ -117,6 +117,15 @@ export default class TextControl<
disabled={this.props.disabled}
aria-label={this.props.label}
/>
+ {hasErrors && (
+ <span
+ id={errorId}
+ role="alert"
+ style={{ color: 'red', fontSize: 'inherit', display: 'block',
marginTop: '4px' }}
+ >
Review Comment:
ADDRESSED: The accidental WCAG 3.3.1 validation code (`hasErrors`/`errorId`)
was reverted in follow-up commit f19c1a6 — that scope belongs to a separate PR.
Current TextControl only contains the 1.4.4 text-resize changes.
##########
superset-frontend/src/SqlLab/components/ScheduleQueryButton/index.tsx:
##########
@@ -108,7 +108,7 @@ export const StyledButtonComponent = styled(Button)`
background: none;
text-transform: none;
padding: 0px;
- font-size: 14px;
+ font-size: ${theme.fontSize}px;
Review Comment:
ADDRESSED: The hardcoded `font-size: 12px` was removed in follow-up commit
f19c1a6 (no font-size declaration remains in ScheduleQueryButton).
##########
superset-frontend/src/explore/components/controls/NumberControl/index.tsx:
##########
@@ -85,6 +85,15 @@ export default function NumberControl({
disabled={disabled}
aria-label={rest.label}
/>
+ {hasErrors && (
+ <span
+ id={errorId}
+ role="alert"
+ style={{ color: 'red', fontSize: 'inherit', display: 'block',
marginTop: '4px' }}
+ >
+ {rest.validationErrors!.join('. ')}
Review Comment:
ADDRESSED: The accidental validation block referencing `hasErrors`/`errorId`
was reverted in follow-up commit f19c1a6. NumberControl no longer contains
undeclared identifiers.
##########
superset-frontend/src/features/databases/DatabaseModal/SSHTunnelForm.tsx:
##########
@@ -79,6 +79,11 @@ const SSHTunnelForm = ({
onChange={onSSHTunnelParametersChange}
data-test="ssh-tunnel-server_address-input"
/>
+ {fieldError('server_address', db?.ssh_tunnel?.server_address) && (
Review Comment:
ADDRESSED: The `fieldError` validation block was removed in follow-up commit
f19c1a6 — it was accidentally included WCAG 3.3.1 scope. SSHTunnelForm no
longer contains that reference.
##########
superset-frontend/src/features/databases/DatabaseModal/SSHTunnelForm.tsx:
##########
@@ -94,6 +99,11 @@ const SSHTunnelForm = ({
onChange={onSSHTunnelParametersChange}
data-test="ssh-tunnel-server_port-input"
/>
+ {fieldError('server_port', db?.ssh_tunnel?.server_port) && (
Review Comment:
ADDRESSED: Same as the server_address thread — the `fieldError` block was
reverted in follow-up commit f19c1a6.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
