Aitema-gmbh commented on code in PR #39235:
URL: https://github.com/apache/superset/pull/39235#discussion_r3232672214
##########
superset-frontend/src/features/databases/DatabaseModal/SSHTunnelForm.tsx:
##########
@@ -111,6 +121,11 @@ const SSHTunnelForm = ({
onChange={onSSHTunnelParametersChange}
data-test="ssh-tunnel-username-input"
/>
+ {fieldError('username', db?.ssh_tunnel?.username) && (
Review Comment:
ADDRESSED: Same as the other SSH `fieldError` threads — reverted in
follow-up commit f19c1a6.
##########
superset-frontend/src/visualizations/TimeTable/components/SparklineCell/SparklineCell.tsx:
##########
@@ -231,7 +231,7 @@ const SparklineCell = ({
<div
css={() => ({
color: theme.colorTextSecondary,
- fontSize: '12px',
+ fontSize: `${theme.fontSizeSM}px`,
Review Comment:
ADDRESSED: The `${theme.fontSizeSM}px` concatenation was replaced with a
scaling `fontSize: '0.85em'` in follow-up commit f84904c — the timestamp now
scales with the surrounding cell font-size for WCAG 1.4.4 compliance.
##########
superset-frontend/src/features/home/Menu.tsx:
##########
@@ -175,6 +175,7 @@ const StyledRow = styled(Row)`
const StyledCol = styled(Col)`
${({ theme }) => css`
display: flex;
+ flex-wrap: wrap;
gap: ${theme.sizeUnit * 4}px;
flex-wrap: wrap;
Review Comment:
ADDRESSED: The duplicate `flex-wrap: wrap` was cleaned up — only a single
declaration remains on line 178.
##########
superset-frontend/src/visualizations/TimeTable/components/SparklineCell/SparklineCell.tsx:
##########
@@ -231,7 +231,7 @@ const SparklineCell = ({
<div
css={() => ({
color: theme.colorTextSecondary,
- fontSize: '12px',
+ fontSize: `${theme.fontSizeSM}px`,
})}
Review Comment:
ADDRESSED: The pixel-based font size was replaced with `fontSize: '0.85em'`
in follow-up commit f84904c, so the timestamp now scales with the surrounding
cell font-size (and inherits browser text-size adjustments) per WCAG 1.4.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
