Aitema-gmbh commented on code in PR #39241:
URL: https://github.com/apache/superset/pull/39241#discussion_r3232687952
##########
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx:
##########
@@ -616,6 +632,8 @@ const DashboardBuilder = () => {
return (
<DashboardWrapper>
{isVerticalFilterBarVisible && (
+ <>
+ <SrOnlyH2>{t('Filters')}</SrOnlyH2>
<ResizableSidebar
Review Comment:
ADDRESSED: Commit 2679d1a removes the outer duplicate `SrOnlyH2` and keeps
the inner one inside `<FiltersPanel hidden={isReport}>` — that's the
semantically correct location since it scopes to the filters container and is
hidden together with it under `isReport`. Screen readers no longer announce
"Filters" twice.
##########
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx:
##########
@@ -351,6 +351,18 @@ const StyledDashboardContent = styled.div<{
`}
`;
+const SrOnlyH2 = styled.h2`
+ position: absolute;
+ width: 1px;
+ height: 1px;
+ padding: 0;
+ margin: -1px;
Review Comment:
ADDRESSED: Commit 2679d1a replaces all SrOnlyH2 styled-component definitions
with the shared `VisuallyHidden` component
(`src/components/Accessibility/VisuallyHidden.tsx`, supports `as="h2"`).
DashboardBuilder uses the shared component now.
##########
superset-frontend/src/pages/Home/index.tsx:
##########
@@ -76,6 +76,18 @@ interface LoadingProps {
const DEFAULT_TAB_ARR = ['dashboards', 'charts'];
+const SrOnlyH1 = styled.h1`
+ position: absolute;
+ width: 1px;
+ height: 1px;
+ padding: 0;
Review Comment:
ADDRESSED: Commit 2679d1a swaps Home/index.tsx to the shared
`VisuallyHidden` component (`as="h1"`). No local SrOnlyH1 styled block remains.
##########
superset-frontend/src/pages/ChartCreation/index.tsx:
##########
@@ -158,6 +158,18 @@ const StyledContainer = styled.div`
`}
`;
+const SrOnlyH1 = styled.h1`
+ position: absolute;
+ width: 1px;
+ height: 1px;
+ padding: 0;
Review Comment:
ADDRESSED: Commit 2679d1a removes the sr-only h1 from ChartCreation entirely
— the page now renders a single visible `<h1>` styled to match the previous h2
size (StyledContainer rule updated from `h2` to `h1`), so no duplicate-heading
or copy-pasted SrOnly CSS remains.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
