Aitema-gmbh commented on code in PR #39241:
URL: https://github.com/apache/superset/pull/39241#discussion_r3232688957
##########
superset-frontend/src/pages/ChartCreation/index.tsx:
##########
@@ -329,7 +341,8 @@ export class ChartCreation extends PureComponent<
return (
<StyledContainer>
- <h3>{t('Create a new chart')}</h3>
+ <SrOnlyH1>{t('Create a new chart')}</SrOnlyH1>
+ <h2 aria-hidden="true">{t('Create a new chart')}</h2>
Review Comment:
ADDRESSED: Exactly the simplification you suggested — commit 2679d1a
collapses the sr-only h1 + aria-hidden visible h2 into a single visible `<h1>`
styled to match the previous h2 size. One semantic heading, no aria-hidden
duplicate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
