mikebridge commented on code in PR #39977:
URL: https://github.com/apache/superset/pull/39977#discussion_r3237695881
##########
superset/daos/base.py:
##########
@@ -181,11 +182,15 @@ def find_by_id_or_uuid(
cls,
model_id_or_uuid: str,
skip_base_filter: bool = False,
+ *,
+ skip_visibility_filter: bool = False,
Review Comment:
In this and other places, this is a flag argument. I would leave it in for
this PR because this is the existing pattern, but we might want to change it
later in tandem with `skip_base_filter`. E.g. it could be `find_by_id_or_uuid`
and `find_by_id_or_uuid_with_soft_deletes`, maybe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
