mikebridge commented on code in PR #39977:
URL: https://github.com/apache/superset/pull/39977#discussion_r3243295851
##########
superset/commands/importers/v1/utils.py:
##########
@@ -424,7 +424,7 @@ def find_existing_for_import(model_cls: type[Any], uuid:
str) -> Any | None:
"""
existing = (
db.session.query(model_cls)
- .execution_options(**{SKIP_VISIBILITY_FILTER: True})
+ .execution_options(**{SKIP_VISIBILITY_FILTER_CLASSES: {model_cls}})
Review Comment:
I'm changing this flag that allows you to override the default omission of
soft-deleted rows (and prevents the predicate from being attached to a query)
so that it is per-entity. I'm worried that a flag that turns it on for all
soft-deleted entity types will be too loose when we start to add new entity
types beyond these three.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
